[FLINK-38899][runtime-web] Introduce the Rescales/History sub-page for streaming jobs with the adaptive scheduler enabled#27874
Conversation
RocMarshal
left a comment
There was a problem hiding this comment.
Hi, @och5351 Thank you for your hard work.
LGTM on the whole, just a few of comments.
PTAL in your free time :)
|
Hi, @RocMarshal ! Thank you. |
|
I checked UI of the PR locally with #27705. checked:
LGTM +1 on the whole just a few of issues:
Thanks @och5351 for the hard work. |
Hi, @RocMarshal ! Could you please review this again? While waiting
Done
|
Thanks @och5351 for the quick updated.
That's a good catch, reasonable! |
RocMarshal
left a comment
There was a problem hiding this comment.
Thanks @och5351 for the update
I'll merge it after the REST API related PRs ready and no more comments from other reviewers.
Thank you, @RocMarshal! |
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <ng-container *ngFor="let history of rescalesHistories; trackBy: trackById"> |
There was a problem hiding this comment.
history -> jobRescaleDetails
There was a problem hiding this comment.
Hi, @RocMarshal !
I submit a new commit now. Could you please confirm it one more time?
| }) | ||
| export class JobRescalesComponent implements OnInit, OnDestroy { | ||
| public rescalesConfig?: RescalesConfig; | ||
| public rescalesHistories?: RescalesHistory; |
There was a problem hiding this comment.
rescalesHistories -> rescalesHistory
| return item.rescaleUuid; | ||
| } | ||
|
|
||
| public onExpandChange(history: BriefJobRescaleDetails, expanded: boolean): void { |
There was a problem hiding this comment.
history -> jobRescaleDetails
| } | ||
|
|
||
| public refresh(): void { | ||
| const expandedUuids = Array.from(this.expandedRowsSet); |
There was a problem hiding this comment.
@RocMarshal
It seemed that the details section (e.g., acquirePrallelism) was not updating even after clicking the refresh button, so I have added some content.
Could you please confirm this change?
There was a problem hiding this comment.
Thanks @och5351
I'll have check before the next review/approve
2cb11c6 to
8181ed2
Compare
| takeUntil(this.destroy$) | ||
| ) | ||
| .subscribe(([config]) => { | ||
| .subscribe(([histories, config]) => { |
fee5f2e to
3f2e7c7
Compare
…r streaming jobs with the adaptive scheduler enabled Co-authored-by: Matthias Pohl <mpohl@confluent.io> Co-authored-by: Yuepeng Pan <hipanyuepeng@gmail.com>
… when the schedulerExecutionMode variable value is null Co-authored-by: Matthias Pohl <mpohl@confluent.io> Co-authored-by: Yuepeng Pan <hipanyuepeng@gmail.com>
|
Thanks @och5351 , merged. |






What is the purpose of the change
Brief change log
Adds the 'Rescales/History' tab and 'HistoryDetail' subpage in relation to [FLINK-38897][Runtime/REST] Introduce /jobs/:jobid/rescales/config endpoint to REST API #27580.
Rescales History Tab
Rescales HistoryDetail page
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation